<html>
<head><meta charset="utf-8"><title>Adjusting the FCP time · wg-governance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/index.html">wg-governance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html">Adjusting the FCP time</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="201124858"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/201124858" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#201124858">(Jun 17 2020 at 10:38)</a>:</h4>
<p>So I've had this proposal for a while that I want to advice:</p>
<p>I think we should eliminate the "Pre-Final-Comment-Period" concept. Basically, when someone writes <code>fcp merge</code>, I think FCP begins <em>right then</em>. It lasts until all of these things have happened:</p>
<ul>
<li>Sufficient team members have checked their boxes</li>
<li>At least 10 days have elapsed</li>
<li>There are no outstanding concerns</li>
</ul>



<a name="201124913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/201124913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#201124913">(Jun 17 2020 at 10:39)</a>:</h4>
<p>I can't recall what amount of "process" we did the last time we changed these procedures; I imagine it would be a PR with core-team sign-off, doesn't necessarily merit an RFC on its own, but I'm also fine writing up a quick RFC (or working with someone in governance WG to so so).</p>



<a name="201179814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/201179814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#201179814">(Jun 17 2020 at 18:12)</a>:</h4>
<p>EDIT: ...I'm sorry, I completely misread something here.</p>



<a name="201179835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/201179835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#201179835">(Jun 17 2020 at 18:12)</a>:</h4>
<p>"all of". So at least 10 days do have to elapse.</p>



<a name="201179924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/201179924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#201179924">(Jun 17 2020 at 18:13)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span> Complete agreement here.</p>



<a name="201637946"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/201637946" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nell Shamrell-Harrington <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#201637946">(Jun 22 2020 at 17:45)</a>:</h4>
<p>I'm in favor of this</p>



<a name="202022971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202022971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202022971">(Jun 25 2020 at 20:48)</a>:</h4>
<p>I want to bring this back up</p>



<a name="202022993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202022993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202022993">(Jun 25 2020 at 20:48)</a>:</h4>
<p>hey <span class="user-mention" data-user-id="130111">@anp</span> do you remember what protocol we used to change the procedures here last time?</p>



<a name="202023013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202023013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202023013">(Jun 25 2020 at 20:49)</a>:</h4>
<p>does this just take a PR against rfcbot and a kind of "fcp core" or something?</p>



<a name="202023036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202023036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202023036">(Jun 25 2020 at 20:49)</a>:</h4>
<p>how hard would it be to make the change I described at the top of this topic?</p>



<a name="202023049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202023049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202023049">(Jun 25 2020 at 20:49)</a>:</h4>
<p>and should I stop picking on <em>you</em> every time I have an rfcbot question?</p>



<a name="202045449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202045449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202045449">(Jun 26 2020 at 01:59)</a>:</h4>
<p>last time changes like that were made was i think <a href="https://github.com/rust-lang/rfcbot-rs/pull/188">https://github.com/rust-lang/rfcbot-rs/pull/188</a></p>
<p>basically the process was "yeah core signs off with something approaching a quorum" but it was at a time when rfcbot was still my personal repo iirc so rfcbot couldn't bootstrap on it. now i don't see why not if you add the right team labels</p>



<a name="202045530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202045530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202045530">(Jun 26 2020 at 02:00)</a>:</h4>
<p>changes to rfcbot have always been a shakily spec'd part of the governance story, at first we navigated that by me being really conservative, then we navigated it by moving it to rust-lang</p>



<a name="202045550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202045550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202045550">(Jun 26 2020 at 02:01)</a>:</h4>
<p>most of the "business logic" resides in <a href="https://github.com/rust-lang/rfcbot-rs/blob/master/src/github/nag.rs">https://github.com/rust-lang/rfcbot-rs/blob/master/src/github/nag.rs</a></p>



<a name="202045617"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202045617" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202045617">(Jun 26 2020 at 02:03)</a>:</h4>
<p>one question i'd pose: should rfcbot still post a comment with "the remaining countdown" i.e. when concerns are resolved and boxes are checked?</p>



<a name="202045637"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202045637" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202045637">(Jun 26 2020 at 02:03)</a>:</h4>
<p>aside: i'm so happy that "ticky boxes" stuck as a term rather than "checkboxes" in that code</p>



<a name="202045685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202045685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202045685">(Jun 26 2020 at 02:04)</a>:</h4>
<p>i think that the change you describe probably looks mostly like a diff to <a href="https://github.com/rust-lang/rfcbot-rs/blob/master/src/github/nag.rs#L315">https://github.com/rust-lang/rfcbot-rs/blob/master/src/github/nag.rs#L315</a></p>



<a name="202122315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202122315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202122315">(Jun 26 2020 at 18:00)</a>:</h4>
<p><span class="user-mention silent" data-user-id="130111">anp</span> <a href="#narrow/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time/near/202045617">said</a>:</p>
<blockquote>
<p>one question i'd pose: should rfcbot still post a comment with "the remaining countdown" i.e. when concerns are resolved and boxes are checked?</p>
</blockquote>
<p>Yes, I think it should definitely post comments when milestones are met.</p>



<a name="202122353"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202122353" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202122353">(Jun 26 2020 at 18:00)</a>:</h4>
<p>I would actually also like it, <span class="user-mention" data-user-id="130111">@anp</span>, if it posted regular reminders to folks, like every N weeks, but we can leave that for later maybe :)</p>



<a name="202345121"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/223182-wg-governance/topic/Adjusting%20the%20FCP%20time/near/202345121" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/223182-wg-governance/topic/Adjusting.20the.20FCP.20time.html#202345121">(Jun 29 2020 at 17:48)</a>:</h4>
<p>The Bytecode Alliance is currently building a Rust-inspired MCP and RFC process. One variation we're considering: we're talking about starting FCP as soon as <em>one</em> other person (apart from the proposer of FCP) signs off, which acts like a "second". That seems like an interesting balance. Not sure if we want to use it, but I wanted to mention it here.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>